Support Laravel 11 #273
Support Laravel 11 #273
Conversation
Only support two latest major versions of Laravel as per Support Policy https://laravel.com/docs/11.x/releases#support-policy Remove Laravel 9 and PHP 8.0 support
This commit can be removed and the correct version of lody use after lorisleiva/lody#6 has been merged
|
This PR looks proper compared to what Laravel Shift attempted |
|
@patrickomeara would you consider adjusting "phpunit/phpunit": "^9.6 || ^10.0" |
|
Good idea @nickfls I have allowed latest versions of Pest and PHPUnit. I leave it up to @lorisleiva to decide whether to release a new major version and remove the lower constraints. |
patrickomeara
force-pushed
the
l11-support
branch
from
ece29dc to
6bdb23d
Compare
There was a problem hiding this comment.
Hi there, thanks for this PR but I'm afraid it's not mergeable because its dependencies need to upgrade first.
The reason Lody is not upgraded yet is because Testbench is still under the -dev tag which makes the Shift PR fail.
I can resolve that manually but I'm afraid I've got very little time for these packages right now.
composer.json
Outdated
| "lorisleiva/lody": "^0.4" | ||
| "php": "^8.1", | ||
| "illuminate/contracts": "^10.0 || ^11.0", | ||
| "lorisleiva/lody": "dev-l11-compatibility" |
There was a problem hiding this comment.
Lody needs to be upgraded first.
There was a problem hiding this comment.
Hi @lorisleiva
I noted that in the commit message
Use Compatible Lody version
This commit can be removed and the correct version of lody use after https://github.com/lorisleiva/lody/pull/6 has been merged
I'm happy for you to use this branch or close it. Whatever is easier.
Thanks for your work.
|
Apologies that it's off-topic, but just wanted to drop in and sincerely thank everyone for getting this through so quickly! I use this library extensively both at work and on the side and this helps us get an early start on Laravel 11 upgrades. 🥳 |
|
Thanks for your work on this @lorisleiva |
Only support two latest major versions of Laravel as per Support Policy https://laravel.com/docs/11.x/releases#support-policy
Remove Laravel 9 and PHP 8.0 support